Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to regular update if delta update fails to download #2118

Merged
merged 1 commit into from
May 2, 2022

Conversation

zorgiepoo
Copy link
Member

Also log out the download failure when a delta update fails to download (such as a 404 error for example).

Additionally, add a check to make sure that top-level appcast items cannot be delta update items.

Fixes #994

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested sparkle-cli gracefully fails when installing update for app where delta update link is 404.
Tested delta update succeeds on normal path.
Tested that sparkle-cli gracefully fails when delta applying fails.
Tested that top-level delta updates are now ignored with sparkle-cli.

macOS version tested: 12.3 (21E230)

Also log out the download failure when a delta update fails to download (such as a 404 error for example).

Additionally, add a check to make sure that top-level appcast items cannot be delta update items.
@zorgiepoo zorgiepoo merged commit 9042c8d into 2.x May 2, 2022
@zorgiepoo zorgiepoo deleted the delta-fallback-fail-download branch May 2, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to download delta update file aborts update instead of falling back to full download
1 participant